mirror of
https://git.openafs.org/openafs.git
synced 2025-01-19 15:30:14 +00:00
d527a80825
The return value of asprintf() is the number of bytes printed, or -1 if there was an error allocating a large enough buffer. In the latter case, the value of the result string is undefined, and so it cannot be counted on to be NULL. This change fixes numerous places where the result of asprintf is checked incorrectly (by examining the output pointer and not the return value) or not at all. Change-Id: I9fef14d60c096795d59c42798f3906041fb18c86 Reviewed-on: http://gerrit.openafs.org/9978 Reviewed-by: Benjamin Kaduk <kaduk@mit.edu> Reviewed-by: D Brashear <shadow@your-file-system.com> Tested-by: BuildBot <buildbot@rampaginggeek.com> |
||
|---|---|---|
| .. | ||
| auth | ||
| bozo | ||
| bucoord | ||
| cmd | ||
| common | ||
| kauth | ||
| opr | ||
| ptserver | ||
| rpctestlib | ||
| rx | ||
| tap | ||
| tests-lib/perl5 | ||
| util | ||
| venus | ||
| volser | ||
| .gitignore | ||
| libwrap | ||
| Makefile.in | ||
| README | ||
| TESTS | ||
This directory contains a test harness and the beginnings of what is
intended to become the primary OpenAFS test suite. The tests in this
directory are run when "make check" is run at the top level of the OpenAFS
tree.
runtests is the test harness, and TESTS is the list of tests that it
will run. If you add a new test, add it to TESTS as well. All tests must
be executables (possibly shell scripts or Perl scripts) that end in either
".t" or "-t", but should be listed in TESTS without that suffix.
Tests should be organized into subdirectories, and where it makes sense to
do so, those subdirectories should match the subdirectory names under src
in the AFS source tree. In other words, tests for src/util/* should go in
a directory named util, tests for the libkopenafs library should go in a
directory named kopenafs, and so forth. To integrate with the build
system, each subdirectory will need to have its own Makefile.in and be
added to the list of generated Makefiles in configure.in at the top
level. The Makefile.in in this directory will also need to be modified
to recurse into any new directories. See util/Makefile.in for an example
of how to write a Makefile.in for a new test directory.
The files comprising the test harness are sourced from the C TAP Harness
distribution using the src/external mechanism. The upstream site for that
distribution is at:
http://www.eyrie.org/~eagle/software/c-tap-harness/
but feel free to propose modifications directly through OpenAFS Gerrit.
Russ Allbery will take care of merging modifications upstream. However,
OpenAFS-specific modifications should not be made to those files. To add
additional OpenAFS-specific code to the TAP library, add additional *.c
and *.h (or *.sh) files to the tests/tap directory rather than modifying files
in src/external.
More information can be found in the HOWTO contained in
src/external/c-tap-harness/HOWTO