mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 15:00:12 +00:00
1073e94779
Since the original IBM code import, UV_RestoreVolume2 (originally UV_RestoreVolume) has checked for VL_ENTDELETED from VLDB_GetEntryByID. However, if VL_ENTDELETED is received, we will act like we retrieved the vlentry successfully. If the -verbose flag is given, we'll try to print the entry (even though one was not returned), and we'll call VL_SetLock for the volume, which will almost certainly also fail with VL_ENTDELETED and bail out. Furthermore (also since the original IBM import), there is no longer any code path to set the volume entry flag VLDELETED. So it should be rare for any VL_* RPC to return VL_ENTDELETED; that would require an entry to have the VLDELETED flag carried over from a very old database. Therefore, it is safe and reasonable to simply remove the check for VL_ENTDELETED from UV_RestoreVolume2. If we do somehow receive the VL_ENTDELETED error code, vos will terminate with an error instead of possibly printing an uninitialized entry. In addition, remove the same check for VL_ENTDELETED in the equivalent code path in libadmin's UV_RestoreVolume. Change-Id: I11d1c3306f67d68de54780f6aac75e4c27779db4 Reviewed-on: https://gerrit.openafs.org/14357 Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> Reviewed-by: Andrew Deason <adeason@sinenomine.net> Tested-by: Andrew Deason <adeason@sinenomine.net> |
||
|---|---|---|
| build-tools | ||
| doc | ||
| src | ||
| tests | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .splintrc | ||
| acinclude.m4 | ||
| CODING | ||
| configure-libafs.ac | ||
| configure.ac | ||
| CONTRIBUTING | ||
| INSTALL | ||
| libafsdep | ||
| LICENSE | ||
| Makefile-libafs.in | ||
| Makefile.in | ||
| NEWS | ||
| NTMakefile | ||
| README | ||
| README-WINDOWS | ||
| regen.sh | ||
AFS is a distributed file system that enables users to share and access all of the files stored in a network of computers as easily as they access the files stored on their local machines. The file system is called distributed for this exact reason: files can reside on many different machines, but are available to users on every machine. OpenAFS 1.0 was originally released by IBM under the terms of the IBM Public License 1.0 (IPL10). For details on IPL10 see the LICENSE file in this directory. The current OpenAFS distribution is licensed under a combination of the IPL10 and many other licenses as granted by the relevant copyright holders. The LICENSE file in this directory contains more details, thought it is not a comprehensive statement. See INSTALL for information about building and installing OpenAFS on various platforms. See CODING for developer information and guidelines. See NEWS for recent changes to OpenAFS.