openafs/tests/common
Andrew Deason 66d0f91791 tests: Wait for server start in auth/superuser-t
The auth/superuser-t test runs an Rx server and client in two child
processes. If the client process tries to contact the server before
the server has started listening on its port, some tests involving
RPCs can fail (notably test 39, "Can run a simple RPC").

Normally if we try to contact a server that's not there, Rx will try
resending its packets a few times, but on Linux with AFS_RXERRQ_ENV,
if the port isn't open at all, we can get an ICMP_PORT_UNREACH error,
which causes the relevant Rx call to die immediately with
RX_CALL_DEAD.

This means that if the auth/superuser-t client is only just a bit
faster than the server starting up, tests can fail, since the server's
port is not open yet.

To avoid this, we can wait until the server's port is open before
starting the client process. To do this, have the server process send
a SIGUSR1 to the parent after rx_Init() is called, and have the parent
process wait for the SIGUSR1 (waiting for a max of 5 seconds before
failing). This should guarantee that the server's port will be open by
the time the client starts running.

Note that before commit 086d1858 (LINUX: Include linux/time.h for
linux/errqueue.h), AFS_RXERRQ_ENV was mistakenly disabled on Linux
3.17+, so this issue was probably not possible on recent Linux before
that commit.

Change-Id: I0032a640b83c24f72c03e7bea100df5bc3d9ed4c
Reviewed-on: https://gerrit.openafs.org/14109
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
2020-03-31 17:34:51 -04:00
..
common.h tests: Wait for server start in auth/superuser-t 2020-03-31 17:34:51 -04:00
config.c tests: Improve afstest_UnlinkTestConfig cleanup 2013-05-28 15:57:31 -07:00
Makefile.in tests: Fix most tests for objdir builds 2019-12-13 00:03:21 -05:00
misc.c tests: Introduce afstest_GetProgname 2020-01-09 23:56:27 -05:00
network.c tests: skip vos tests when a vlserver is already running 2020-01-20 15:16:14 -05:00
rxkad.c tests: Move token faking code to its own file 2012-04-22 06:18:19 -07:00
servers.c tests: Wait for server start in auth/superuser-t 2020-03-31 17:34:51 -04:00
ubik.c tests: Abstract out code to produce a Ubik client 2012-04-22 06:17:17 -07:00