mirror of
https://git.openafs.org/openafs.git
synced 2025-01-31 05:27:44 +00:00
9ef6aac17a
In a few perl scripts (that happen to be for macOS), we check whether '$? >> 8' is zero to see whether a command failed. But the value of '$? >> 8' is just the exit code of the process. If it instead, for example, was killed by a signal, there is no exit code, and '$? >> 8' may not be accurate (the terminating signal is in '$? & 127'). We should check if $? is nonzero at all to see if an error happened. To avoid any possible issues, update all of our checks for command failure to check if $? is nonzero, instead of '$? >> 8'. In notarize.pl, print out the whole status in addition to the exit code, just to be clear in case the command somehow terminates from a signal. Change-Id: I07ed145fae45d0bdc77c1249cf4d89bd5ba5cc56 Reviewed-on: https://gerrit.openafs.org/15980 Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> Reviewed-by: Cheyenne Wills <cwills@sinenomine.net> Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net> Tested-by: Andrew Deason <adeason@sinenomine.net> Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Included in this directory are copies of the files used to create OpenAFS binary packages. It will be endeavored to keep them up to date, however, the files in the binary packaging system used by the vendor (the debian directory as used by Debian or the srpm for RedHat packages) is currently canonical. These should be treated as reference material only.