mirror of
https://git.openafs.org/openafs.git
synced 2025-01-31 13:38:01 +00:00
1c4dc26584
ih_sync_thread currently syncs files flagged as needing synchronization in the background every 10 seconds. This practice has caused severe data corruption on more than one occasion over the past few years (124359, 131530). It has also been argued repeatedly that it provides no meaningful additional on-disk consistency, so there is no reason for it to exist even if it were error-free. Syncing files in the background provides no guarantee on the consistency of the file contents, since the files are not synced in any order with respect to each other, or with respect to what filesystem operations may be occurring in the application. Additionally, journalling filesystems common on fileserver backends will typically ensure some consistency after a certain amount of time (by default, 5 seconds on ZFS and ext3+), so doing this sync ourselves is often redundant or even counterproductive. So, to avoid current and future issues with ih_sync_thread interacting with other ihandle users, just get rid of it. Files flagged as needing sync are still synced (not in the background) during IH_REALLYCLOSE. FIXES 131530 Change-Id: I29571c82c5b7454cd834b339fd48baeb9963a87b Reviewed-on: http://gerrit.openafs.org/8797 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Derrick Brashear <shadow@your-file-system.com>