mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 15:00:12 +00:00
4f8a5b1a22
Currently, volinfo/volscan offers an optional -volumeid parameter, allowing users to specify the id of a single volume to generate output for. If this option is omitted, volinfo/volscan processes every volume in the specified partition, or all local partitions if no partition is specified. Internally, when the -volumeid parameter is not provided, its corresponding variable defaults to 0, which volinfo/volscan interprets as an indication to process all volumes. Unfortunately, if an invalid volume id is specified (e.g., a volume name instead of a number), volinfo/volscan incorrectly treats it as 0 and processes all volumes instead of validating the input and notifying the user. This issue occurs because strtoul(), the function used to convert the volume id string to a number, returns 0 when it fails to perform a valid conversion, leading volinfo/volscan to misinterpret invalid volume ids as 0. This commit fixes this issue by adding validation for the -volumeid option. It parses the result from strtoul() and returns an error if the volume id is invalid. This ensures that users are properly informed when an invalid id is provided, preventing unintended processing of all volumes in the given partition. Change-Id: I166211c8814c13f4a79273efa6408a447f0855a9 Reviewed-on: https://gerrit.openafs.org/15771 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> Reviewed-by: Andrew Deason <adeason@sinenomine.net> |
||
|---|---|---|
| build-tools | ||
| doc | ||
| src | ||
| tests | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .splintrc | ||
| acinclude.m4 | ||
| CODING | ||
| configure-libafs.ac | ||
| configure.ac | ||
| CONTRIBUTING | ||
| INSTALL | ||
| libafsdep | ||
| LICENSE | ||
| Makefile-libafs.in | ||
| Makefile.in | ||
| NEWS | ||
| NTMakefile | ||
| README | ||
| README-WINDOWS | ||
| regen.sh | ||
AFS is a distributed file system that enables users to share and access all of the files stored in a network of computers as easily as they access the files stored on their local machines. The file system is called distributed for this exact reason: files can reside on many different machines, but are available to users on every machine. OpenAFS 1.0 was originally released by IBM under the terms of the IBM Public License 1.0 (IPL10). For details on IPL10 see the LICENSE file in this directory. The current OpenAFS distribution is licensed under a combination of the IPL10 and many other licenses as granted by the relevant copyright holders. The LICENSE file in this directory contains more details, thought it is not a comprehensive statement. See INSTALL for information about building and installing OpenAFS on various platforms. See CODING for developer information and guidelines. See NEWS for recent changes to OpenAFS.