mirror of
https://git.openafs.org/openafs.git
synced 2025-01-31 05:27:44 +00:00
60c44d0d02
Currently, tests/rx/perf-t calls functions like WIFSIGNALED and
WTERMSIG on $?. However, functions like WTERMSIG expect the native
exit status code (that is, ${^CHILD_ERROR_NATIVE}). The $? var (aka
$CHILD_ERROR), is a synthetic value calculated by perl that stores the
term sig in the lowest 7 bits, and the exit code in the second-lowest
8 bits.
For most modern platforms, these two values tend to be the same. But
on modern AIX (and some other weird platforms, like VMS and BeOS), the
exit status integer is encoded differently. On AIX specifically, the
term sig is in the third-lowest 8 bits, so a process exiting on signal
15 would result in an exit status (${^CHILD_ERROR_NATIVE}) of 0xf000f,
but $? would be just 0xf. Calling WTERMSIG on 0xf000f returns 0xf, but
calling WTERMSIG on 0xf returns 0x0.
All of this means that running rx/perf-t causes the final test to fail
with "Server died with signal 0" (even when the process was killed by
signal 15), which is rather confusing.
To fix this, call WTERMSIG et al with ${^CHILD_ERROR_NATIVE} instead
of $?. Create a local var so we don't need to spell out
${^CHILD_ERROR_NATIVE} so many times.
Change-Id: I3c27642fcaf17c320a94caf57d3665d4b6a4a76e
Reviewed-on: https://gerrit.openafs.org/14706
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
50 lines
1.2 KiB
Perl
Executable File
50 lines
1.2 KiB
Perl
Executable File
#!/usr/bin/env perl
|
|
|
|
use strict;
|
|
use warnings;
|
|
|
|
use Test::More tests=>4;
|
|
use POSIX qw(:sys_wait_h :signal_h);
|
|
|
|
my $port = 4000;
|
|
my $build = $ENV{C_TAP_BUILD};
|
|
$build = ".." if (!defined($build));
|
|
my $rxperf = $build."/../src/tools/rxperf/rxperf";
|
|
|
|
# Start up an rxperf server
|
|
|
|
my $pid = fork();
|
|
if ($pid == -1) {
|
|
fail("Failed to fork rxperf server");
|
|
exit(1);
|
|
} elsif ($pid == 0) {
|
|
exec({$rxperf}
|
|
"rxperf", "server", "-p", $port, "-u", "1024", "-H", "-N");
|
|
die("Kabooom ?");
|
|
}
|
|
pass("Started rxperf server");
|
|
|
|
# Start up an rxperf client, and run a test
|
|
is(0,
|
|
system("$rxperf client -c rpc -p $port -S 1048576 -R 1048576 -T 30 -u 1024 -H -N"),
|
|
"single threaded client ran successfully");
|
|
|
|
is (0,
|
|
system("$rxperf client -c rpc -p $port -S 1048576 -R 1048576 -T 1 -t 30 -u 1024 -H -N"),
|
|
"multi threaded client ran succesfully");
|
|
|
|
# Kill the server, and check its exit code
|
|
|
|
kill("TERM", $pid);
|
|
waitpid($pid, 0);
|
|
my $ecode = ${^CHILD_ERROR_NATIVE};
|
|
if (WIFSIGNALED($ecode) && WTERMSIG($ecode) != SIGTERM) {
|
|
fail("Server died with signal ".WTERMSIG($ecode));
|
|
} elsif (WIFEXITED($ecode) && WEXITSTATUS($ecode) != 0) {
|
|
fail("Server exited with code". WEXITSTATUS($ecode));
|
|
} else {
|
|
pass("Server exited succesfully");
|
|
}
|
|
|
|
|