mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 15:00:12 +00:00
6e5cbd7ccb
DirAccessOK() currently uses two static vars (lastTime, lastResult) to cache the result of the function to avoid overly-frequent stat()s. These are not documented as being protected by any locks. Currently they cannot be accessed by two different threads at the same time; the only callers are: - SBOZO_GetInstanceInfo(), which calls it with BNODE_LOCK held - main(), which calls it before our rx service threads are started But this is fragile and not documented. To avoid potential issues in the future, document DirAccessOK() as requiring BNODE_LOCK, assert that we have BNODE_LOCK in DirAccessOK(), and acquire BNODE_LOCK before calling DirAccessOK() from main(). While we're here, move the declarations for the two static vars so they're next to each other, so it's a little more obvious that we have some static variables here. Change-Id: I4e0e55cd8a7ebbb681e4da937efcc9c37633e3ab Reviewed-on: https://gerrit.openafs.org/15837 Reviewed-by: Benjamin Kaduk <kaduk@mit.edu> Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> |
||
|---|---|---|
| build-tools | ||
| doc | ||
| src | ||
| tests | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .splintrc | ||
| acinclude.m4 | ||
| CODING | ||
| configure-libafs.ac | ||
| configure.ac | ||
| CONTRIBUTING | ||
| INSTALL | ||
| libafsdep | ||
| LICENSE | ||
| Makefile-libafs.in | ||
| Makefile.in | ||
| NEWS | ||
| NTMakefile | ||
| README | ||
| README-WINDOWS | ||
| regen.sh | ||
AFS is a distributed file system that enables users to share and access all of the files stored in a network of computers as easily as they access the files stored on their local machines. The file system is called distributed for this exact reason: files can reside on many different machines, but are available to users on every machine. OpenAFS 1.0 was originally released by IBM under the terms of the IBM Public License 1.0 (IPL10). For details on IPL10 see the LICENSE file in this directory. The current OpenAFS distribution is licensed under a combination of the IPL10 and many other licenses as granted by the relevant copyright holders. The LICENSE file in this directory contains more details, thought it is not a comprehensive statement. See INSTALL for information about building and installing OpenAFS on various platforms. See CODING for developer information and guidelines. See NEWS for recent changes to OpenAFS.