openafs

mirror of https://git.openafs.org/openafs.git synced 2025-01-18 06:50:12 +00:00

History

Mark Vitale 55fca11421 rx: fix out-of-range value for RX_CONN_NAT_PING Commit `496fb87372` ("rx: avoid nat ping until connection is attached") introduced functionality to defer turning on NAT ping for server connections until after reachability had been established for the client. Unfortunately, this feature could never work correctly because it assigned an out-of-range flag value of 256 (0x100) for the u_char flags field. Instead of calling this out as an error, both gcc and Solaris cc elide this flag so that it is never set in rx_SetConnSecondsUntilNatPing(), Furthermore, the test in rxi_ConnClearAttachWait() will always fail; therefore rxi_ScheduleNatKeepAliveEvent is never called after attach wait has ended. Fortunately, this bug is currently moot - not actually exposed in OpenAFS. (It was discovered by inspection). This is because there are currently no rx_connection objects in the tree that have both NAT ping and checkReach (rx_SetCheckReach) enabled. I also searched git history and found no time when this bug could ever have been exposed. This does raise the question of why the original commit was needed; but instead of reverting the original commit, this commit attempts to fix it. To prevent problems if NAT ping and checkReach are ever both enabled for an rx_connection, enlarge the rx_connection flags member so that the RX_CONN_NAT_PING value is no longer out of range. Change-Id: Ib667ece632f66fa5c63a76398acb3153fed6f9c3 Reviewed-on: https://gerrit.openafs.org/13041 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>		2020-07-23 23:06:14 -04:00
..
doxygen	Cleanup vestiges of old shared library build directories	2020-03-05 21:53:26 -05:00
man-pages	vos: fix name availability check in vos rename	2020-01-31 12:54:51 -05:00
pdf	initial-pdf-with-embedded-cmr-fonts-20010606	2001-06-06 18:58:13 +00:00
protocol	lwp: remove preemption support	2016-05-05 12:51:14 -04:00
txt	rx: fix out-of-range value for RX_CONN_NAT_PING	2020-07-23 23:06:14 -04:00
xml	doc: the last partition name is /vicepiu	2018-09-14 08:35:26 -04:00
LICENSE	Rework the Kerberos Autoconf probes	2010-06-15 16:30:04 -07:00
README	doc: relocate notes from arch to txt	2017-08-03 20:44:28 -04:00

README

What's in the "doc" subdirectory

** doc/man-pages
pod sources for man pages (converted from original IBM html source).

** doc/xml
xml sources for manuals (converted from original IBM html source).
Note: The doc/xml/AdminRef uses doc/xml/AdminRef/pod2refentry to convert the
pod man pages to xml for printing.  pod goes directly to html just fine.

** doc/pdf
Old Transarc (and possibly pre-Transarc) protocol and API documentation for
which we have no other source.

** doc/txt
Technical notes, Windows notes, and examples.

** doc/doxygen
Configuration files for the doxygen tool to generate documentation from
the annotated sources. See the 'dox' Makefile target in the top level
Makefile.