mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 06:50:12 +00:00
900d89380d
When the fileserver saves its callback state to disk on shutdown, fs_stateCreateDump sets state->mode to FS_STATE_DUMP_MODE. But this is after some code paths have already looked at state->mode, such as fs_stateSave -> h_stateVerify -> h_Enumerate_r -> h_stateVerifyHost -> h_stateVerifyAddrHash. This doesn't cause any problems right now, since the value of FS_STATE_DUMP_MODE is 0, and we zero the whole 'state' struct when it is initialized. This is confusing, though, so move the assignment of FS_STATE_DUMP_MODE to earlier in the state-saving process, before anything looks at it. To try to avoid possible uninitialized use of state->mode in the future, change the FS_STATE_*_MODE constants so that none of them are 0, and make sure that code checking the 'mode' checks that the mode is a valid constant. [adeason@sinenomine.net: Added state mode checking.] Change-Id: Ifa5e5aabdb7c7b4a50a1b397620aafa7c48c223e Reviewed-on: https://gerrit.openafs.org/14726 Reviewed-by: Mark Vitale <mvitale@sinenomine.net> Reviewed-by: Cheyenne Wills <cwills@sinenomine.net> Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Andrew Deason <adeason@sinenomine.net> |
||
|---|---|---|
| build-tools | ||
| doc | ||
| src | ||
| tests | ||
| .gitignore | ||
| .gitreview | ||
| .mailmap | ||
| .splintrc | ||
| acinclude.m4 | ||
| CODING | ||
| configure-libafs.ac | ||
| configure.ac | ||
| CONTRIBUTING | ||
| INSTALL | ||
| libafsdep | ||
| LICENSE | ||
| Makefile-libafs.in | ||
| Makefile.in | ||
| NEWS | ||
| NTMakefile | ||
| README | ||
| README-WINDOWS | ||
| regen.sh | ||
AFS is a distributed file system that enables users to share and access all of the files stored in a network of computers as easily as they access the files stored on their local machines. The file system is called distributed for this exact reason: files can reside on many different machines, but are available to users on every machine. OpenAFS 1.0 was originally released by IBM under the terms of the IBM Public License 1.0 (IPL10). For details on IPL10 see the LICENSE file in this directory. The current OpenAFS distribution is licensed under a combination of the IPL10 and many other licenses as granted by the relevant copyright holders. The LICENSE file in this directory contains more details, thought it is not a comprehensive statement. See INSTALL for information about building and installing OpenAFS on various platforms. See CODING for developer information and guidelines. See NEWS for recent changes to OpenAFS.