mirror of
https://git.openafs.org/openafs.git
synced 2025-01-31 05:27:44 +00:00
Andrew Deason
9f052c137d
afs: Remove SRXAFSCB_GetDE
The GetDE RPC has been commented out from afscbint.xg effectively since it was introduced, but we still define the SRXAFSCB_GetDE server stub for it. This is useless, but also potentially dangerous, since the stub routine just returns success, without populating the output arguments. One of the output arguments is a string, and so if this RPC is actually run, the rxgen-generated server code will try to xdr_string() that string. Since we never set it to anything, this will result in xdr_string trying to dereference a NULL pointer. None of this actually happens currently, since the GetDE RPC is commented out. But to avoid the above situation if it's ever uncommented, remove the useless SRXAFSCB_GetDE function. Reviewed-on: https://gerrit.openafs.org/14488 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Benjamin Kaduk <kaduk@mit.edu> (cherry picked from commit 444a971edc47c34efbefed6e332ee6e843ae072b) Change-Id: I83846d79ce3143571923cb6023075620091f093d Reviewed-on: https://gerrit.openafs.org/15681 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Andrew Deason <adeason@sinenomine.net> Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
AFS is a distributed file system that enables users to share and access all of the files stored in a network of computers as easily as they access the files stored on their local machines. The file system is called distributed for this exact reason: files can reside on many different machines, but are available to users on every machine. OpenAFS 1.0 was originally released by IBM under the terms of the IBM Public License 1.0 (IPL10). For details on IPL10 see the LICENSE file in this directory. The current OpenAFS distribution is licensed under a combination of the IPL10 and many other licenses as granted by the relevant copyright holders. The LICENSE file in this directory contains more details, thought it is not a comprehensive statement. See INSTALL for information about building and installing OpenAFS on various platforms. See CODING for developer information and guidelines. See NEWS for recent changes to OpenAFS.
Description
Languages
C
72.2%
C++
20.1%
Makefile
1.4%
Perl
1.2%
Rich Text Format
1%
Other
3.7%