mirror of
https://git.openafs.org/openafs.git
synced 2025-01-19 07:20:11 +00:00
7293ddf325
We currently attempt to align our XDR implementation with what may be provided by the host system. This leads to a huge amount of parameter fudging, and general pain and misfortune. However, the only place that we still actually use the system XDR is for UKERNEL builds. Change this so that we use our XDR everywhere. Fix all of our type and function definitions so that they're standard. Remove the warning inhibitions. Change-Id: I53f4539e50eacb4e0691d8d3d6546bbfb7438358 Reviewed-on: http://gerrit.openafs.org/1340 Reviewed-by: Chaz Chandler Tested-by: Chaz Chandler Reviewed-by: Derrick Brashear <shadow@dementia.org> Tested-by: Derrick Brashear <shadow@dementia.org> Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
70 lines
3.2 KiB
Plaintext
70 lines
3.2 KiB
Plaintext
OpenAFS Warning detection
|
|
-------------------------
|
|
|
|
There's been a concerted effort over the last few years, by many developers,
|
|
to reduce the number of warnings in the OpenAFS tree. In an attempt to
|
|
prevent warnings from creeping back in, we now have the ability to break the
|
|
build when new warnings appear.
|
|
|
|
This is only available for systems with gcc 4.2 or later, and is disabled
|
|
unless the --enable-checking option is supplied to configure. Because we
|
|
can't remove all of the warnings, we permit file by file (and warning by
|
|
warning) disabling of specific warnings. The --enable-checking=all prevents
|
|
this, and errors for any file containing a warning.
|
|
|
|
Disabling warnings
|
|
------------------
|
|
|
|
If warnings are unavoidable in a particular part of the build, they may be
|
|
disabled in an number of ways.
|
|
|
|
You can disable a single warning type in a particular file by using GCC
|
|
pragmas. If a warning can be disabled with a pragma, then the switch to use
|
|
will be listed in the error message you receive from the compiler. Pragmas
|
|
should be wrapped in IGNORE_SOME_GCC_WARNINGS, so that they aren't used
|
|
with non-gcc compilers, and can be disabled if desired. For example:
|
|
#ifdef IGNORE_SOME_GCC_WARNINGS
|
|
# pragma GCC diagnostic warning "-Wold-style-definition"
|
|
#endif
|
|
|
|
If a pragma isn't available for your particular warning, you will need to
|
|
disable all warnings for the file in question. You can do this by supplying
|
|
the autoconf macro @CFLAGS_NOERROR@ in the build options for the file. For
|
|
example:
|
|
lex.yy.o : lex.yy.c y.tab.c
|
|
${CC} -c ${CFLAGS} @CFLAGS_NOERROR@ lex.yy.c
|
|
|
|
If you add a new warning inhibition, please also add it to the list below.
|
|
|
|
Inhibited warnings
|
|
------------------
|
|
|
|
afs/afs_syscall.c : old-style
|
|
: strict-proto
|
|
: all (ukernel) : syscall pointer issues
|
|
afsd/afsd.c : deprecated : daemon() marked as deprecated on Darwin
|
|
: all : call_syscall missing prototype
|
|
auth/ktc.c : all (ukernel) : call_syscall doesn't have a prototype
|
|
bozo/bosserver.c : deprecated : daemon() marked as deprecated on Darwin
|
|
bucoord/ubik_db_if.c : strict-proto : Ubik_Call
|
|
bucoord/commands.c : all : Ubik_Call
|
|
: signed vs unsigned for dates
|
|
butc/tcudbprocs.c : all : ubik_Call
|
|
kauth/admin_tools.c : all : ubik_Call nonsense
|
|
kauth/authclient.c : strict-proto : ubik_Call nonsense
|
|
libadmin/bos/afs_bosAdmin.c: all : time types, and const
|
|
libadmin/kas/afs_kasAdmin.c: all : Ubik_Call nonsense
|
|
libadmin/samples/rxstat_query_peer.c : all : util_RPCStatsStateGet types
|
|
libadmin/samples/rxstat_query_process.c : all : util_RPCStatsStateGet types
|
|
libadmin/test/client.c : all : util_RPCStatsStateGet types
|
|
rx/rx.c : all (pthread) : rxkad_global_stats_init not proto'd
|
|
ubik/beacon.c : all : Ubik uses signed/unsigned
|
|
interchangably for IP addresses, a
|
|
fix will require API changes.
|
|
ubik/ubikclient.c : strict-protos : ubik_Call
|
|
uss/uss_kauth.c : all : ubik_Call
|
|
viced/fsprobe.c : all : ubik_Call
|
|
vol/salvager.c : all : consts & undefined variable from header - maybe fixed!
|
|
volser/vol-dump.c : format : afs_sfsize_t
|
|
|