jimzah/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2024-11-26 23:22:44 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

LLD patch: Do not keep shared symbols to garbage...

Browse Source 
-collected eliminated DSOs.

This applies https://reviews.llvm.org/D45536 to the embedded
LLD.

Closes #883
This commit is contained in:
Andrew Kelley 2018-04-11 18:02:27 -04:00
parent ed1b028276
commit 2b86ffe34a
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
deps/lld/ELF/MarkLive.cpp vendored
View File

@ -301,6 +301,15 @@ template <class ELFT> void elf::markLive() {
// Follow the graph to mark all live sections. // Follow the graph to mark all live sections.
doGcSections<ELFT>(); doGcSections<ELFT>();
// If all references to a DSO happen to be weak, the DSO is removed from
// DT_NEEDED, which creates dangling shared symbols to non-existent DSO.
// We'll replace such symbols with undefined ones to fix it.
for (Symbol *Sym : Symtab->getSymbols())
if (auto *S = dyn_cast<SharedSymbol>(Sym))
if (S->isWeak() && !S->getFile<ELFT>().IsNeeded)
replaceSymbol<Undefined>(S, nullptr, S->getName(), STB_WEAK, S->StOther,
S->Type);
// Report garbage-collected sections. // Report garbage-collected sections.
if (Config->PrintGcSections) if (Config->PrintGcSections)
for (InputSectionBase *Sec : InputSections) for (InputSectionBase *Sec : InputSections)