From 60954598e9de71defb9ab07cef35a17082151d36 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Thu, 3 Feb 2022 14:01:32 -0700 Subject: [PATCH] apply zig patches to clang and llvm tools --- src/zig_clang_driver.cpp | 24 +++++++++++++++--------- src/zig_llvm-ar.cpp | 12 ++++++++++-- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/src/zig_clang_driver.cpp b/src/zig_clang_driver.cpp index a7bfb07e00..1f24131f14 100644 --- a/src/zig_clang_driver.cpp +++ b/src/zig_clang_driver.cpp @@ -207,8 +207,6 @@ extern int cc1_main(ArrayRef Argv, const char *Argv0, void *MainAddr); extern int cc1as_main(ArrayRef Argv, const char *Argv0, void *MainAddr); -extern int cc1gen_reproducer_main(ArrayRef Argv, - const char *Argv0, void *MainAddr); static void insertTargetAndModeArgs(const ParsedClangName &NameParts, SmallVectorImpl &ArgVector, @@ -318,22 +316,28 @@ static int ExecuteCC1Tool(SmallVectorImpl &ArgV) { if (Tool == "-cc1as") return cc1as_main(makeArrayRef(ArgV).slice(2), ArgV[0], GetExecutablePathVP); - if (Tool == "-cc1gen-reproducer") - return cc1gen_reproducer_main(makeArrayRef(ArgV).slice(2), ArgV[0], - GetExecutablePathVP); // Reject unknown tools. llvm::errs() << "error: unknown integrated tool '" << Tool << "'. " << "Valid tools include '-cc1' and '-cc1as'.\n"; return 1; } -int main(int Argc, const char **Argv) { +extern "C" int ZigClang_main(int Argc, const char **Argv); +int ZigClang_main(int Argc, const char **Argv) { noteBottomOfStack(); - llvm::InitLLVM X(Argc, Argv); + // ZIG PATCH: On Windows, InitLLVM calls GetCommandLineW(), + // and overwrites the args. We don't want it to do that, + // and we also don't need the signal handlers it installs + // (we have our own already), so we just use llvm_shutdown_obj + // instead. + // llvm::InitLLVM X(Argc, Argv); + llvm::llvm_shutdown_obj X; + llvm::setBugReportMsg("PLEASE submit a bug report to " BUG_REPORT_URL " and include the crash backtrace, preprocessed " "source, and associated run script.\n"); - SmallVector Args(Argv, Argv + Argc); + size_t argv_offset = (strcmp(Argv[1], "-cc1") == 0 || strcmp(Argv[1], "-cc1as") == 0) ? 0 : 1; + SmallVector Args(Argv + argv_offset, Argv + Argc); if (llvm::sys::Process::FixupStandardFileDescriptors()) return 1; @@ -432,7 +436,9 @@ int main(int Argc, const char **Argv) { ApplyQAOverride(Args, OverrideStr, SavedStrings); } - std::string Path = GetExecutablePath(Args[0], CanonicalPrefixes); + // Pass local param `Argv[0]` as fallback. + // See https://github.com/ziglang/zig/pull/3292 . + std::string Path = GetExecutablePath(Argv[0], CanonicalPrefixes); // Whether the cc1 tool should be called inside the current process, or if we // should spawn a new clang subprocess (old behavior). diff --git a/src/zig_llvm-ar.cpp b/src/zig_llvm-ar.cpp index 8842162f52..c959f339a2 100644 --- a/src/zig_llvm-ar.cpp +++ b/src/zig_llvm-ar.cpp @@ -1274,8 +1274,16 @@ static int ranlib_main(int argc, char **argv) { return performOperation(CreateSymTab, nullptr); } -int main(int argc, char **argv) { - InitLLVM X(argc, argv); +extern "C" int ZigLlvmAr_main(int argc, char **argv); +int ZigLlvmAr_main(int argc, char **argv) { + // ZIG PATCH: On Windows, InitLLVM calls GetCommandLineW(), + // and overwrites the args. We don't want it to do that, + // and we also don't need the signal handlers it installs + // (we have our own already), so we just use llvm_shutdown_obj + // instead. + // InitLLVM X(argc, argv); + llvm::llvm_shutdown_obj X; + ToolName = argv[0]; llvm::InitializeAllTargetInfos();