jimzah/zig
1
0
Fork 0
mirror of https://github.com/ziglang/zig.git synced 2024-12-04 19:09:32 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PriorityQueue: use compareFn in update()

Browse Source 
update() calls mem.indexOfScalar() which uses `==` for comparing items,
which fails when the operator is not supported.
As PirorityQueue needs a comparing function anyway we can use `.eq` results
to identify matching objects.

closes #9918
This commit is contained in:
VÖRÖSKŐI András 2022-07-17 22:42:31 +02:00 committed by Veikka Tuominen
parent d1d892c83c
commit d925d19cfc
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/std/priority_queue.zig
View File

@ -219,7 +219,12 @@ pub fn PriorityQueue(comptime T: type, comptime Context: type, comptime compareF
}
pub fn update(self: *Self, elem: T, new_elem: T) !void {
var update_index: usize = std.mem.indexOfScalar(T, self.items[0..self.len], elem) orelse return error.ElementNotFound;
const update_index = blk: {
for (self.items) |item, idx| {
if (compareFn(self.context, item, elem).compare(.eq)) break :blk idx;
}
return error.ElementNotFound;
};
const old_elem: T = self.items[update_index];
self.items[update_index] = new_elem;
switch (compareFn(self.context, new_elem, old_elem)) {