Avoid executable headers in local include tree

sys_prototypes.h, afs_AdminErrors.h, and afs_Admin.h were being installed
into include/ in the build tree via ${INSTALL} instead of ${INSTALL_DATA}.
rx_prototypes.h was executable in the repository.  Install header files
non-executable and make rx_prototypes.h non-executable for cleanliness.

Discovered by Lintian because the executable permissions were duplicated
by make libafs_tree.

Change-Id: I609b62f69d1fecc2cdbba7e7442d93e9675c2fa0
Reviewed-on: http://gerrit.openafs.org/1129
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
This commit is contained in:
Russ Allbery 2010-01-19 17:43:35 -08:00 committed by Derrick Brashear
parent 340d3be82a
commit 5dddb87eb3
4 changed files with 3 additions and 3 deletions

View File

@ -15,7 +15,7 @@ INSTALL_SCRIPT = @INSTALL_SCRIPT@
all: ${TOP_INCDIR}/afs/afs_Admin.h
${TOP_INCDIR}/afs/afs_Admin.h: afs_Admin.h
${INSTALL} $? $@
${INSTALL_DATA} $? $@
install:
${INSTALL} -d ${DESTDIR}${includedir}/afs

View File

@ -34,7 +34,7 @@ ${TOP_INCDIR}/afs/afs_utilAdmin.h: afs_utilAdmin.h
${INSTALL_DATA} $? $@
afs_AdminBosErrors.c ${DESTDIR}/include/afs/afs_AdminBosErrors.h: afs_AdminBosErrors.et
${INSTALL} ${srcdir}/afs_AdminErrors.h ${TOP_INCDIR}/afs
${INSTALL_DATA} ${srcdir}/afs_AdminErrors.h ${TOP_INCDIR}/afs
$(RM) -f afs_AdminBosErrors.c afs_AdminBosErrors.h
${COMPILE_ET} -p ${srcdir} afs_AdminBosErrors.et -h afs_AdminBosErrors
cp afs_AdminBosErrors.h ${TOP_INCDIR}/afs/afs_AdminBosErrors.h

0
src/rx/rx_prototypes.h Executable file → Normal file
View File

View File

@ -58,7 +58,7 @@ ${TOP_INCDIR}/afs/xfsattrs.h: xfsattrs.h
${INSTALL_DATA} $? $@
${TOP_INCDIR}/afs/sys_prototypes.h: sys_prototypes.h
${INSTALL} $? $@
${INSTALL_DATA} $? $@
${TOP_LIBDIR}/libsys.a: libsys.a
${INSTALL_DATA} $? $@