jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-31 05:27:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dir: Remove double release in FindBlobs

Browse Source 
When DRead() fails, we DRelease the entrybuf, then break. However,
this break takes us to the end of the function, where we promptly
DRelease again, causing a double free

Change-Id: I5a0293990e01376525d8adae25477c64e2cc93ad
Reviewed-on: http://gerrit.openafs.org/5655
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
This commit is contained in:
Simon Wilkinson 2011-10-10 19:01:26 -05:00 committed by Derrick Brashear
parent 69f54d4748
commit ab866c821a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/dir/dir.c
View File

@ -235,7 +235,6 @@ FindBlobs(dir_file_t dir, int nblobs)
/* read the page in. */ /* read the page in. */
if (DRead(dir, i, &pagebuf) != 0) { if (DRead(dir, i, &pagebuf) != 0) {
DRelease(&headerbuf, 1);
break; break;
} }
pp = (struct PageHeader *)pagebuf.data; pp = (struct PageHeader *)pagebuf.data;