jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

OPENAFS-SA-2018-002 kaserver: prevent KAM_ListEntry information leak

Browse Source 
KAM_ListEntry (kas list) does not initialize its output correctly.  It
leaks kaserver memory contents over the wire:

struct kaindex
- up to 64 bytes for member name
- up to 64 bytes for member instance

Initialize the buffer.

[kaduk@mit.edu: move initialization to top of server routine]

Change-Id: I5cc430fc996e7e89d38a384d092b9d4fad248fa4
This commit is contained in:
Mark Vitale 2018-06-26 05:26:21 -04:00 committed by Benjamin Kaduk
parent be0142707c
commit b604ee7add
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/kauth/kaprocs.c
View File

@ -1700,6 +1700,7 @@ kamListEntry(struct rx_call *call,
afs_int32 caller; afs_int32 caller;
struct kaentry tentry; struct kaentry tentry;
memset(name, 0, sizeof(*name));
COUNT_REQ(ListEntry); COUNT_REQ(ListEntry);
if ((code = InitAuthServ(&tt, LOCKREAD, this_op))) if ((code = InitAuthServ(&tt, LOCKREAD, this_op)))
return code; return code;