jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-18 23:10:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

rx: Remove needless braces

Browse Source 
Doing if ((a==b)) is unecessary. It's also potentially dangerous, as
that's the syntax required to do assignment within an if statement.
clang now issues warnings (errors in -Werror mode) when it encounters
these.

Remove pointless braces from the Unix CM to make clang happy.

Reviewed-on: http://gerrit.openafs.org/7088
Tested-by: Simon Wilkinson <simonxwilkinson@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 5e107724f3)

Change-Id: I82833f58df0fa54234a04796bee8ae464e001ac6
Reviewed-on: http://gerrit.openafs.org/7158
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
This commit is contained in:
Simon Wilkinson 2012-03-30 19:39:51 +01:00 committed by Jeffrey Altman
parent cb4d73b7a3
commit b7ed23f479
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/rx/rx_user.c
View File

@ -609,7 +609,7 @@ rx_GetIFInfo(void)
fudge_netmask(rxi_NetAddrs[rxi_numNetAddrs]);
#ifdef SIOCGIFNETMASK
res = ioctl(s, SIOCGIFNETMASK, ifr);
if ((res == 0)) {
if (res == 0) {
a = (struct sockaddr_in *)&ifr->ifr_addr;
myNetMasks[rxi_numNetAddrs] = ntohl(a->sin_addr.s_addr);
/* fprintf(stderr, "if %s subnetmask=0x%x\n",