jimzah/openafs
1
0
Fork 0
mirror of https://git.openafs.org/openafs.git synced 2025-01-19 15:30:14 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

LINUX: Avoid duplicate mntget in afs_dentry_open

Browse Source 
Our caller already got a ref to 'mnt'; getting another one here will
overcount refs on 'mnt'.

This can make it impossible to unmount the filesystem the cache
resides on (even after the client is stopped), since it's ref count
will be very high.

FIXES 131613

Change-Id: I3f0cd0fd6c0c2ced74f2d799ea0d8f8701a20141
Reviewed-on: http://gerrit.openafs.org/9790
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Marc Dionne <marc.c.dionne@gmail.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
This commit is contained in:
Andrew Deason 2013-04-17 01:27:47 -05:00 committed by Derrick Brashear
parent 7647c6c4a1
commit e019429d45
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/afs/LINUX/osi_compat.h
View File

@ -529,7 +529,7 @@ afs_dentry_open(struct dentry *dp, struct vfsmount *mnt, int flags, const struct
filp = dentry_open(&path, flags, creds); filp = dentry_open(&path, flags, creds);
return filp; return filp;
#else #else
return dentry_open(dp, mntget(mnt), flags, creds); return dentry_open(dp, mnt, flags, creds);
#endif #endif
} }
#endif #endif