mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 15:00:12 +00:00
6ace773fdc
The rx/perf test can occasionally fail due to the rxperf server not being fully initialized before the client started. This can cause test errors, even without changes to the rx code. C_TAP_VERBOSE=1 make check TESTS="rx/perf" ... rx/perf 1..4 ok 1 - Started rxperf server not ok 2 - single threaded client ran successfully RPC: threads 30, times 1, write bytes 1048576, read bytes... ok 3 - multi threaded client ran succesfully ok 4 - Server exited succesfully FAILED 2 (exit status 1) Add a routine that waits for the rx_perf server to become available. Loop several times trying the connection via the rx_perf client, with a short delay between retries. If the connection cannot be established, fail the test. Clean up trailing whitespace on a couple of lines. Note: This failure was observed in an OpenAFS buildbot worker that included a make tests, and which would occasionally fail when there was no rx related code changes. The intermittent failure could be duplicated on a slower virtual test system, but would not fail on a faster system. Thanks to mmeffie@sinenomine.net for the 'wait_for_server' contribution. Change-Id: Ie11e0d726ce287c45a677f3bb799388121aafc1e Reviewed-on: https://gerrit.openafs.org/15676 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Benjamin Kaduk <kaduk@mit.edu> Reviewed-by: Andrew Deason <adeason@sinenomine.net> |
||
|---|---|---|
| .. | ||
| auth | ||
| bozo | ||
| bucoord | ||
| cmd | ||
| common | ||
| kauth | ||
| opr | ||
| ptserver | ||
| rx | ||
| tap | ||
| tests-lib/perl5 | ||
| util | ||
| venus | ||
| volser | ||
| .gitignore | ||
| libwrap | ||
| Makefile.in | ||
| README | ||
| TESTS | ||
This directory contains a test harness and the beginnings of what is
intended to become the primary OpenAFS test suite. The tests in this
directory are run when "make check" is run at the top level of the OpenAFS
tree.
runtests is the test harness, and TESTS is the list of tests that it
will run. If you add a new test, add it to TESTS as well. All tests must
be executables (possibly shell scripts or Perl scripts) that end in either
".t" or "-t", but should be listed in TESTS without that suffix.
Tests should be organized into subdirectories, and where it makes sense to
do so, those subdirectories should match the subdirectory names under src
in the AFS source tree. In other words, tests for src/util/* should go in
a directory named util, tests for the libkopenafs library should go in a
directory named kopenafs, and so forth. To integrate with the build
system, each subdirectory will need to have its own Makefile.in and be
added to the list of generated Makefiles in configure.in at the top
level. The Makefile.in in this directory will also need to be modified
to recurse into any new directories. See util/Makefile.in for an example
of how to write a Makefile.in for a new test directory.
The files comprising the test harness are sourced from the C TAP Harness
distribution using the src/external mechanism. The upstream site for that
distribution is at:
http://www.eyrie.org/~eagle/software/c-tap-harness/
but feel free to propose modifications directly through OpenAFS Gerrit.
Russ Allbery will take care of merging modifications upstream. However,
OpenAFS-specific modifications should not be made to those files. To add
additional OpenAFS-specific code to the TAP library, add additional *.c
and *.h (or *.sh) files to the tests/tap directory rather than modifying files
in src/external.
More information can be found in the HOWTO contained in
src/external/c-tap-harness/HOWTO