mirror of
https://git.openafs.org/openafs.git
synced 2025-01-18 06:50:12 +00:00
99ca5c0c22
Each C-TAP test is statically linked with libafstest_common as well as any libaries under test. However, not all tests have these libraries listed as dependencies in their respective make rules. Thus when development changes are made to the c-tap harness, the OpenAFS common code (tests/common/*), or the libraries under test, these tests may not be rebuilt. This results in unexpected test output and confusion. Add the libafstest_common library (and other OpenAFS libraries as needed) as dependencies for all the test targets that require them. [mmeffie: remove MODULE_LIBS from auth/Makefile.in] Change-Id: If14d27237cc6d18a424c88b0594e8c6cde1888e4 Reviewed-on: https://gerrit.openafs.org/15725 Tested-by: BuildBot <buildbot@rampaginggeek.com> Reviewed-by: Mark Vitale <mvitale@sinenomine.net> Reviewed-by: Cheyenne Wills <cwills@sinenomine.net> Reviewed-by: Michael Meffie <mmeffie@sinenomine.net> |
||
---|---|---|
.. | ||
auth | ||
bozo | ||
bucoord | ||
cmd | ||
common | ||
kauth | ||
opr | ||
ptserver | ||
rx | ||
tap | ||
tests-lib/perl5 | ||
util | ||
venus | ||
volser | ||
.gitignore | ||
libwrap | ||
Makefile.in | ||
README | ||
TESTS |
This directory contains a test harness and the beginnings of what is intended to become the primary OpenAFS test suite. The tests in this directory are run when "make check" is run at the top level of the OpenAFS tree. runtests is the test harness, and TESTS is the list of tests that it will run. If you add a new test, add it to TESTS as well. All tests must be executables (possibly shell scripts or Perl scripts) that end in either ".t" or "-t", but should be listed in TESTS without that suffix. Tests should be organized into subdirectories, and where it makes sense to do so, those subdirectories should match the subdirectory names under src in the AFS source tree. In other words, tests for src/util/* should go in a directory named util, tests for the libkopenafs library should go in a directory named kopenafs, and so forth. To integrate with the build system, each subdirectory will need to have its own Makefile.in and be added to the list of generated Makefiles in configure.in at the top level. The Makefile.in in this directory will also need to be modified to recurse into any new directories. See util/Makefile.in for an example of how to write a Makefile.in for a new test directory. The files comprising the test harness are sourced from the C TAP Harness distribution using the src/external mechanism. The upstream site for that distribution is at: http://www.eyrie.org/~eagle/software/c-tap-harness/ but feel free to propose modifications directly through OpenAFS Gerrit. Russ Allbery will take care of merging modifications upstream. However, OpenAFS-specific modifications should not be made to those files. To add additional OpenAFS-specific code to the TAP library, add additional *.c and *.h (or *.sh) files to the tests/tap directory rather than modifying files in src/external. More information can be found in the HOWTO contained in src/external/c-tap-harness/HOWTO